Issue 149: Implement off-heap cache storage #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not really sure that using ByteBufInputStream can be faster that deserializing to a byte[] and then reading data from a ByteArrayInputStream, because ByteBufInputStream will perform a lot of Unsafe operations instead of a single copy from Direct to Heap, only benchmarks will give the answer |
eolivelli
requested review from
mcRoot,
caliuf,
diegosalvi,
mino181295 and
nicoloboschi
|
Fixes #149 |
caliuf
reviewed
Jan 9, 2019
| import java.lang.ref.SoftReference; | ||
| import java.util.Arrays; | ||
| import java.util.logging.Level; | ||
| import java.util.logging.Logger; | ||
|
|
||
| /** | ||
| * Una entry nella cache |
There was a problem hiding this comment.
Comment in italian. Not important
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Netty Direct ByteBufs to store data.
Introduce refcounting of CacheEntry objects in order to be able to release direct memory