Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write ledger header #572

Merged
merged 6 commits into from
Mar 5, 2020
Merged

Write ledger header #572

merged 6 commits into from
Mar 5, 2020

Conversation

eolivelli
Copy link
Contributor

  • write an entry to the ledger before adding it to the list of active ledgers
  • this is a workaround to a possible fault case in BookKeeper when there is no entry on the Bookie and one Bookie goes down

- write an entry to the ledger before adding it to the list of active ledgers
- this is a workaround to a possible fault case in BookKeeper when there is no entry on the Bookie and one Bookie goes down
@eolivelli
Copy link
Contributor Author

eolivelli commented Mar 4, 2020

The attached test case fails without this fix and reproduces the problems seen by @hamadodene in his test environment

@coveralls
Copy link

Pull Request Test Coverage Report for Build 690

  • 24 of 33 (72.73%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.03%) to 64.66%

Changes Missing Coverage Covered Lines Changed/Added Lines %
herddb-core/src/main/java/herddb/cluster/BookkeeperCommitLog.java 24 33 72.73%
Files with Coverage Reduction New Missed Lines %
herddb-core/src/main/java/herddb/core/TableManager.java 1 82.06%
herddb-core/src/main/java/herddb/model/Transaction.java 1 84.98%
herddb-utils/src/main/java/herddb/index/blink/BLink.java 1 71.75%
herddb-core/src/main/java/herddb/core/TableSpaceManager.java 6 79.3%
Totals Coverage Status
Change from base Build 683: 0.03%
Covered Lines: 16337
Relevant Lines: 25266

💛 - Coveralls

@diegosalvi diegosalvi merged commit 4432730 into master Mar 5, 2020
@diegosalvi diegosalvi deleted the fix/write-ledger-header branch March 5, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants