Fix bv_typet SMT2 parse bug
#3119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`bv_typet` is not supported by `numeric_cast_v`, causing multiple issues in `smt2_conv.cpp`. This fix removes inappropriate use of `bv_typet` and `ID_bv`.
This was referenced Oct 8, 2018
Closed
allredj
reviewed
Oct 8, 2018
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 3a9fab6).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87186900
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
pkesseli
added a commit
that referenced
this pull request
Oct 12, 2018
Temporary quick-fix for `fastsynth` users. Fixed in: #3119
4 tasks
|
#3284 has this plus the tests! |
|
Superseded by #3284. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bv_typetis not supported bynumeric_cast_v, causing multiple issuesin
smt2_conv.cpp. This fix removes inappropriate use ofbv_typetand
ID_bv.This fix is tested in: #3120