Skip to content

Conversation

pkesseli
Copy link
Contributor

@pkesseli pkesseli commented Oct 8, 2018

Add SMT back-end regression tests for entities with a conversion to bitvectors.

These tests test the bugfix of the SMT2 back-end introduced in #3119 and will only pass once it is merged.

Add regression tests for entities with a conversion to bitvectors.
Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very much on-board with the idea but I think Daniel had concerns about adding Z3 to the CI set-up.

Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments below; there are two existing tests in the regression/cbmc folder marked "smt-backend" that should be moved to the new cbmc-smt folder. And then of course CI needs to be brought to the point where the tests pass ;-)

@@ -64,9 +69,10 @@ phases:
cd ../..

- |
$env:Path = "C:\tools\cygwin\bin;$env:Path"
$env:Path = "C:\tools\cygwin\bin;C:\tools\cygwin\bin;c:\tools\z3-4.7.1-x64-win\bin;$env:Path"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate C:\tools\cygwin\bin directory

CORE
main.c
--smt2
activate-multi-line-match
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems unnecessary as no multi-line patterns are being used?

CORE
main.c
--smt2 --fpa
activate-multi-line-match
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems unnecessary?

CORE
main.c
--smt2
activate-multi-line-match
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems unnecessary?

main.c
--smt2
activate-multi-line-match
^EXIT=10$
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should also have at least one test that actually verifies successfully?

@pkesseli
Copy link
Contributor Author

pkesseli commented Nov 9, 2018

I think this is at least partially superseded by #3284. I'm not sure whether it's worth adding the z3 dependency now just to cover a few more edge cases. Opinions, @tautschnig @kroening ?

@TGWDB
Copy link
Contributor

TGWDB commented May 19, 2021

Closing as this is effectively superseded and very out of date. Please reopen if you believe this is erroneous and plan to rebase and update.

@TGWDB TGWDB closed this May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants