-
Notifications
You must be signed in to change notification settings - Fork 280
Add SMT regression tests #3120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SMT regression tests #3120
Conversation
Add regression tests for entities with a conversion to bitvectors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very much on-board with the idea but I think Daniel had concerns about adding Z3 to the CI set-up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments below; there are two existing tests in the regression/cbmc
folder marked "smt-backend" that should be moved to the new cbmc-smt
folder. And then of course CI needs to be brought to the point where the tests pass ;-)
@@ -64,9 +69,10 @@ phases: | |||
cd ../.. | |||
|
|||
- | | |||
$env:Path = "C:\tools\cygwin\bin;$env:Path" | |||
$env:Path = "C:\tools\cygwin\bin;C:\tools\cygwin\bin;c:\tools\z3-4.7.1-x64-win\bin;$env:Path" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate C:\tools\cygwin\bin
directory
CORE | ||
main.c | ||
--smt2 | ||
activate-multi-line-match |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems unnecessary as no multi-line patterns are being used?
CORE | ||
main.c | ||
--smt2 --fpa | ||
activate-multi-line-match |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems unnecessary?
CORE | ||
main.c | ||
--smt2 | ||
activate-multi-line-match |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems unnecessary?
main.c | ||
--smt2 | ||
activate-multi-line-match | ||
^EXIT=10$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should also have at least one test that actually verifies successfully?
I think this is at least partially superseded by #3284. I'm not sure whether it's worth adding the |
Closing as this is effectively superseded and very out of date. Please reopen if you believe this is erroneous and plan to rebase and update. |
Add SMT back-end regression tests for entities with a conversion to bitvectors.
These tests test the bugfix of the SMT2 back-end introduced in #3119 and will only pass once it is merged.