-
Notifications
You must be signed in to change notification settings - Fork 280
smt2 bit vector fix [blocks: any PR adding CBMC tests] #3284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine modulo the one comment.
`bv_typet` is not supported by `numeric_cast_v`, causing multiple issues in `smt2_conv.cpp`. This fix removes inappropriate use of `bv_typet` and `ID_bv`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 33cfe25).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90470839
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite like the delete script; would prefer adding a tag to the .desc file as done for excluding tests that don't yet run with symex-driven lazy loading, but ok; hope this becomes obsolete soon.
@peterschrammel Let's say we'll get the number of non-working tests below 50, and then we switch to the flag! |
This is #3119 plus a commit that enables the SMT2 tests that subsequently pass.