Skip to content

Conversation

kroening
Copy link
Member

@kroening kroening commented Nov 6, 2018

This is #3119 plus a commit that enables the SMT2 tests that subsequently pass.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine modulo the one comment.

kroening and others added 3 commits November 6, 2018 18:42
`bv_typet` is not supported by `numeric_cast_v`, causing multiple issues
in `smt2_conv.cpp`.  This fix removes inappropriate use of `bv_typet`
and `ID_bv`.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 33cfe25).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90470839

@tautschnig tautschnig changed the title smt2 bit vector fix smt2 bit vector fix [blocks: any PR adding CBMC tests] Nov 7, 2018
Copy link
Member

@peterschrammel peterschrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite like the delete script; would prefer adding a tag to the .desc file as done for excluding tests that don't yet run with symex-driven lazy loading, but ok; hope this becomes obsolete soon.

@peterschrammel peterschrammel removed their assignment Nov 7, 2018
@tautschnig tautschnig merged commit 8ba1734 into develop Nov 7, 2018
@tautschnig tautschnig deleted the smt2-bv-fix branch November 7, 2018 16:50
@kroening
Copy link
Member Author

kroening commented Nov 7, 2018

@peterschrammel Let's say we'll get the number of non-working tests below 50, and then we switch to the flag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants