Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add services monitoring section to admin panel. #26

Merged
merged 5 commits into from
Oct 5, 2022

Conversation

cristianberneanu
Copy link
Contributor

Oh boy, I spent way too long on this 😕... My initial approach was to create separate components for each service and use mount / unmount events to control service startup and shutdown. This would have the nice effect of easily creating a dependency hierarchy between services, allowing, for example, automatic shutdown of Metabase when PostgreSQL crashes.

I got something mostly working, but it seemed a bit too complicated and kind of weird to allow the presentation layer to control application logic. I also realized that, most likely, we don't need these complex behaviors.

In the end, I opted to simplify things significantly by making main control each service lifetime and having the Services component only reflect the current status of managed services.

This PR includes some temporary code for testing, which I'll remove when merging it with your previous changes.

Copy link
Collaborator

@pdobacz pdobacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Once you merge, I'll work on adapting the init/startup scripts to this

@pdobacz
Copy link
Collaborator

pdobacz commented Oct 5, 2022

Sorry about the conflicts - these should be relatively easy to resolve - the new TableListStep should sit in between the new Service status step and FileLoadStep. Since they're rather orthogonal, they should blend together well in the code. Let me know if you need help with any of this.

@cristianberneanu
Copy link
Contributor Author

No worries, conflicts are par for the course at this stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants