Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow import of CSV into assumed PG instance #7

Merged
merged 3 commits into from
Sep 28, 2022
Merged

Allow import of CSV into assumed PG instance #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e427b4
Allow import of CSV into assumed PG instance.
pdobacz Sep 22, 2022
4ae0bcb
Add `pg-native` and appease `npm run package` and CI
pdobacz Sep 27, 2022
b933da2
`npm update node-abi`
pdobacz Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion gui/assets/locales/en/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,11 @@
"DataPreviewHelp": {
"Data Preview": "Data Preview",
"Use the data preview to confirm that the data was imported correctly.": "Use the data preview to confirm that the data was imported correctly."
},
"AidSelectionHelp": {
"ID Selection": "ID Selection",
"<strong>WARNING:</strong> If this configuration is not done correctly, the data will not be properly anonymized.": "<strong>WARNING:</strong> If this configuration is not done correctly, the data will not be properly anonymized.",
"If the data has one row per person (or other <1>protected entity</1>), then no entity identifier column need be selected. Otherwise, select a column containing a unique ID per protected entity. <4>Click here for details on how to set.</4>": "If the data has one row per person (or other <1>protected entity</1>), then no entity identifier column need be selected. Otherwise, select a column containing a unique ID per protected entity. <4>Click here for details on how to set.</4>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like at all the amount of duplication and noise the current translation approach creates.
This is especially annoying for long strings. I think we should start using some shorter tags for the keys, i.e. "AidConfigurationWarning".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, but let's have a separate issue for this (also to handle uniformly in desktop, once we have the spare cycles)

}
},
"FileLoadStep": {
Expand All @@ -86,6 +91,9 @@
"CAUTION:": "CAUTION:",
"When no identifier column is present in the data, you must ensure that each individual row from the input file represents a unique entity.": "When no identifier column is present in the data, you must ensure that each individual row from the input file represents a unique entity.",
"Select a column or 'None'": "Select a column or 'None'",
"[None]": "[None]"
"[None]": "[None]",
"Importing CSV from {{fileName}}...": "Importing CSV from {{fileName}}...",
"Data from {{fileName}} imported successfully!": "Data from {{fileName}} imported successfully!",
"Data import failed!": "Data import failed!"
}
}
Loading