Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add expo-font package, add Rubik Regular and Rubik-Medium fonts #382

Merged
merged 2 commits into from
May 29, 2024

Conversation

bohdanprog
Copy link
Collaborator

  • add expo-font package
  • add Rubik Regular and Rubik Medium fonts.

Copy link
Member

@achou11 achou11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of suggestions but otherwise changes make sense to me!

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@achou11
Copy link
Member

achou11 commented May 29, 2024

Based on what's detailed in https://openfontlicense.org/how-to-use-ofl-fonts/, might also make sense to include the font's license file (if you downloaded from Google fonts, it's the file named OFL.txt).

@bohdanprog
Copy link
Collaborator Author

@achou11 I fixed everything, if it's okay we can merge that :)

@bohdanprog bohdanprog merged commit aa2b218 into main May 29, 2024
3 checks passed
@bohdanprog bohdanprog deleted the feat/fonts branch May 29, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants