Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated validations-logic for CommandService and CommandSubmissionService #572

Closed
gerolf-da opened this issue Apr 17, 2019 · 0 comments · Fixed by #1227
Closed

Remove duplicated validations-logic for CommandService and CommandSubmissionService #572

gerolf-da opened this issue Apr 17, 2019 · 0 comments · Fixed by #1227
Labels
component/ledger Sandbox and Ledger API

Comments

@gerolf-da
Copy link
Contributor

Commands sent to the CommandSubmissionService are validated by CommandSubmissionRequestValidator, whereas commands sent to the CommandService are validated by CommandPayloadValidations.
The validation logic has diverged a little (wrt workflow_id and application_id), therefore we should really unify that and only have a single validation path.
@gerolf-da gerolf-da added the component/ledger Sandbox and Ledger API label Apr 17, 2019
stefanobaghino-da added a commit that referenced this issue May 17, 2019
@stefanobaghino-da
Unify command validation logic
ddc3e17 
Fixes #572
stefanobaghino-da added a commit that referenced this issue May 17, 2019
@stefanobaghino-da
Unify command validation logic
326129d 
Fixes #572
@stefanobaghino-da stefanobaghino-da mentioned this issue May 17, 2019
Merged
5 tasks
stefanobaghino-da added a commit that referenced this issue May 17, 2019
@stefanobaghino-da
Unify command validation logic (#1227)
2858f55 
* Unify command validation logic

Fixes #572

* Fix formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/ledger Sandbox and Ledger API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify command validation logic digital-asset/daml
1 participant
@gerolf-da