Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated validations-logic for CommandService and CommandSubmissionService #572

Closed
gerolf-da opened this issue Apr 17, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@gerolf-da
Copy link
Contributor

commented Apr 17, 2019

Commands sent to the CommandSubmissionService are validated by CommandSubmissionRequestValidator, whereas commands sent to the CommandService are validated by CommandPayloadValidations.
The validation logic has diverged a little (wrt workflow_id and application_id), therefore we should really unify that and only have a single validation path.

stefanobaghino-da added a commit that referenced this issue May 17, 2019

stefanobaghino-da added a commit that referenced this issue May 17, 2019

@stefanobaghino-da stefanobaghino-da referenced this issue May 17, 2019

Merged

Unify command validation logic #1227

4 of 5 tasks complete

stefanobaghino-da added a commit that referenced this issue May 17, 2019

Unify command validation logic (#1227)
* Unify command validation logic

Fixes #572

* Fix formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.