Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vsce ivocation in cron #2093

Merged
merged 1 commit into from
Jul 10, 2019
Merged

fix vsce ivocation in cron #2093

merged 1 commit into from
Jul 10, 2019

Conversation

garyverhaegen-da
Copy link
Contributor

It looks like without this change, bazel run @daml_extension_deps//vsce/bin:vsce runs with $PWD set to the folder where the vsce executable is. At least on my machine. This seems really weird.

Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I actually wonder if we don’t need to do the same for yarn. Afaik, bazel run will always run in some weird working directory.

@garyverhaegen-da
Copy link
Contributor Author

Trying it locally, it does not look like we need it for yarn. I have no idea why. The internet seems to say the original behaviour was to run in a random directory, but that supposedly has been changed to run under the current directory (where bazel run was invoked) about 6 months ago.

@cocreature
Copy link
Contributor

Hm, maybe it is something about the nodejs_binary thing that messes up the working directory? If it works I’m happy 🙂

@garyverhaegen-da garyverhaegen-da merged commit 631c8e2 into master Jul 10, 2019
@garyverhaegen-da garyverhaegen-da deleted the fix-vscode-cron branch July 10, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants