Idempotent package uploads #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da-tanabe
force-pushed
the
sandbox-jdbc-package-upload-resolution
branch
7 times, most recently
from
74664a3
to
ca1c11f
Compare
stefanobaghino-da
suggested changes
Jul 15, 2019
stefanobaghino-da
suggested changes
Jul 15, 2019
...c/main/scala/com/digitalasset/platform/sandbox/stores/ledger/sql/dao/PostgresLedgerDao.scala
Outdated
Show resolved
Hide resolved
...c/main/scala/com/digitalasset/platform/sandbox/stores/ledger/sql/dao/PostgresLedgerDao.scala
Show resolved
Hide resolved
...c/main/scala/com/digitalasset/platform/sandbox/stores/ledger/sql/dao/PostgresLedgerDao.scala
Outdated
Show resolved
Hide resolved
da-tanabe
force-pushed
the
sandbox-jdbc-package-upload-resolution
branch
3 times, most recently
from
2dd8385
to
6b86f46
Compare
...r/sandbox/src/main/scala/com/digitalasset/platform/sandbox/stores/ledger/sql/SqlLedger.scala
Show resolved
Hide resolved
...c/main/scala/com/digitalasset/platform/sandbox/stores/ledger/sql/dao/PostgresLedgerDao.scala
Outdated
Show resolved
Hide resolved
stefanobaghino-da
force-pushed
the
sandbox-jdbc-package-upload-resolution
branch
from
6b86f46
to
b375f8c
Compare
|
Took over @da-tanabe's work to add tests and some logging, ready for review. |
stefanobaghino-da
approved these changes
Jul 26, 2019
|
Fun fact: by working on someone else's PR you can approve your own contribution. |
stefanobaghino-da
changed the title
gerolf-da
requested changes
Jul 29, 2019
...r/sandbox/src/main/scala/com/digitalasset/platform/sandbox/stores/ledger/sql/SqlLedger.scala
Outdated
Show resolved
Hide resolved
gerolf-da
approved these changes
Jul 29, 2019
Co-Authored-By: Gerolf Seitz <gerolf.seitz@digitalasset.com>
stefanobaghino-da
force-pushed
the
sandbox-jdbc-package-upload-resolution
branch
from
4e845ea
to
515a76f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes package uploads idempotent.
Fixes #2130.
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.