-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return archived events from /command/exercise #3036
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
returning a `ActiveContract` instead of `GetActiveContractsResponse`
it is an empty array instead of empty GetActiveContractResponse object
…bmit-output # Conflicts: # ledger-service/http-json/README.md # ledger-service/http-json/src/main/scala/com/digitalasset/http/ContractsService.scala # ledger-service/http-json/src/main/scala/com/digitalasset/http/domain.scala # ledger-service/http-json/src/main/scala/com/digitalasset/http/json/JsonProtocol.scala
leo-da
changed the title
Leo 2925 command submit output
Return archived events from /command/exercise
Sep 25, 2019
Improving integration tests, asserting values in the response JSON
set it to empty string (default), it is optional in the Ledger API
S11001001
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return
ArchivedContract
andActiveContract
objects from/command/exercise
endpointSee: #2925
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines run
totrigger the build.