Bundle packages with SDK releases #3056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aherrmann-da
requested review from
a user,
cocreature,
bame-da and
nickchapman-da
cocreature
approved these changes
Sep 30, 2019
compiler/damlc/lib/DA/Cli/Damlc.hs
Outdated
| mbSdkPath <- handleIO (\_ -> pure Nothing) $ Just <$> getSdkPath | ||
| let isSdkPackage fp = takeExtension fp /= ".dar" | ||
| handleSdkPackages :: [FilePath] -> IO [FilePath] | ||
| handleSdkPackages = case mbSdkPath of |
There was a problem hiding this comment.
Might be easier to read if you do the case split inside of expand.
There was a problem hiding this comment.
Agreed that's clearer, I've changed the code.
I figured lifting the case match outside was probably more efficient. But, that's likely premature optimization and not really necessary.
Rename the trigger library package to match other builtin packages.
aherrmann-da
force-pushed
the
da-triggers-sdk
branch
from
5106ec4
to
786a19f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2979
$DAML_SDK/daml-libs.daml.yaml'sdependenciesby package name without.darextension.daml-triggerpackage. (Package will change in the future)Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.