Add GenMap support in the compiler. #3437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
cocreature,
hurryabit,
a user and
remyhaemmerle-da
hurryabit
reviewed
Nov 12, 2019
hurryabit
approved these changes
Nov 12, 2019
remyhaemmerle-da
approved these changes
Nov 12, 2019
cocreature
approved these changes
Nov 13, 2019
| @@ -211,6 +212,14 @@ typeOfBuiltin = \case | |||
| BEMapDelete -> pure $ TForall (alpha, KStar) $ TText :-> TMap tAlpha :-> TMap tAlpha | |||
| BEMapToList -> pure $ TForall (alpha, KStar) $ TMap tAlpha :-> TList (TMapEntry tAlpha) | |||
| BEMapSize -> pure $ TForall (alpha, KStar) $ TMap tAlpha :-> TInt64 | |||
| BEGenMapEmpty -> pure $ TForall (alpha, KStar) $ TForall (beta, KStar) $ TGenMap tAlpha tBeta | |||
There was a problem hiding this comment.
Perhaps that is nitpicking but I would find this easier to read if we called the type variables k and v or key and value.
ghost
added
the
bame-da
pushed a commit
that referenced
this pull request
Nov 19, 2019
* Add GenMap support in the compiler. * Add GenMap ticket number in Upgrade.hs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR advances the implementation of #2256.
This PR adds all the GenMap support that should be necessary in the compiler. That includes:
DAML_GENMAPBTGenMapandBEGenMap_*to the LF ASTThis PR does not update the stdlib.