Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add genmap in scenario service #3483

Merged
merged 1 commit into from
Nov 15, 2019
Merged

add genmap in scenario service #3483

merged 1 commit into from
Nov 15, 2019

Conversation

remyhaemmerle-da
Copy link
Collaborator

This PR advances #2256.

It add the GenMap value to the scenario service.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Add a line to the release notes, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@remyhaemmerle-da remyhaemmerle-da added the component/daml-engine DAML-LF Engine & Interpreter label Nov 15, 2019
@remyhaemmerle-da remyhaemmerle-da added this to the Maintenance milestone Nov 15, 2019
@remyhaemmerle-da remyhaemmerle-da requested review from a user and cocreature November 15, 2019 10:47
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@remyhaemmerle-da remyhaemmerle-da merged commit 0e92bc6 into master Nov 15, 2019
@remyhaemmerle-da remyhaemmerle-da deleted the scenario-genmap branch November 15, 2019 11:39
bame-da pushed a commit that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/daml-engine DAML-LF Engine & Interpreter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants