DAML-LF: add GenMap in iface reader #3487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyhaemmerle-da
requested review from
leo-da,
rautenrieth-da,
S11001001 and
stefanobaghino-da
as code owners
remyhaemmerle-da
added
component/daml-lf
remyhaemmerle-da
force-pushed
the
daml-lf-genmap
branch
from
ba3c113
to
e8e38fc
Compare
remyhaemmerle-da
changed the title
stefanobaghino-da
approved these changes
Nov 15, 2019
remyhaemmerle-da
force-pushed
the
daml-lf-genmap
branch
from
e8e38fc
to
c774904
Compare
remyhaemmerle-da
force-pushed
the
daml-lf-genmap
branch
from
c774904
to
e1aa37c
Compare
S11001001
previously requested changes
Nov 15, 2019
language-support/scala/codegen/src/main/scala/com/digitalasset/codegen/lf/LFUtil.scala
Outdated
Show resolved
Hide resolved
…/codegen/lf/LFUtil.scala Co-Authored-By: Stephen Compall <stephen.compall@daml.com>
remyhaemmerle-da
dismissed
S11001001’s stale review
S11001001 allow me to demiss his request once I applied his suggestions
bame-da
pushed a commit
that referenced
this pull request
Nov 19, 2019
* daml-lf: add GenMap in iface reader * remove useless code * Update language-support/scala/codegen/src/main/scala/com/digitalasset/codegen/lf/LFUtil.scala Co-Authored-By: Stephen Compall <stephen.compall@daml.com> * please restart CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR advances the state of #2256.
Here we add GenMap in the interface reader.
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.