Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAML LF: expose generic equality in LF #3752

Merged
merged 4 commits into from
Dec 6, 2019
Merged

DAML LF: expose generic equality in LF #3752

merged 4 commits into from
Dec 6, 2019

Conversation

remyhaemmerle-da
Copy link
Collaborator

@remyhaemmerle-da remyhaemmerle-da commented Dec 5, 2019 •
edited
Loading

This PR advances the state of #3766.

With this PR, daml-lf exposes generic equality.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@remyhaemmerle-da remyhaemmerle-da changed the title Daml lf geneq 2 DAML LF: expose generic eqaulity in LF Dec 5, 2019
@remyhaemmerle-da remyhaemmerle-da changed the title DAML LF: expose generic eqaulity in LF DAML LF: expose generic equality in LF Dec 5, 2019
@remyhaemmerle-da remyhaemmerle-da force-pushed the daml-lf-geneq-2 branch 2 times, most recently from 684cbb7 to c9debda Compare December 6, 2019 11:54
@remyhaemmerle-da remyhaemmerle-da marked this pull request as ready for review December 6, 2019 11:54
ghost
ghost approved these changes Dec 6, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I like the removal of all the redundant equal builtins. :-)

daml-lf/interpreter/src/test/scala/com/digitalasset/daml/lf/speedy/SBuiltinTest.scala Outdated Show resolved Hide resolved
compiler/daml-lf-proto/src/DA/Daml/LF/Proto3/DecodeV1.hs Outdated Show resolved Hide resolved
cocreature
cocreature approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@remyhaemmerle-da remyhaemmerle-da added this to the Maintenance milestone Dec 6, 2019
@mergify mergify bot merged commit e055b2b into master Dec 6, 2019
@mergify mergify bot deleted the daml-lf-geneq-2 branch December 6, 2019 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocreature cocreature cocreature approved these changes

@hurryabit hurryabit Awaiting requested review from hurryabit

@leo-da leo-da Awaiting requested review from leo-da

@S11001001 S11001001 Awaiting requested review from S11001001

@gerolf-da gerolf-da Awaiting requested review from gerolf-da

Assignees
No one assigned
Labels
component/daml-lf DAML-LF
Projects
None yet
Milestone
Maintenance
Development

Successfully merging this pull request may close these issues.
2 participants
@remyhaemmerle-da @cocreature