Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing bug for mishandling potential offset gaps #802

Merged
merged 11 commits into from May 2, 2019

Conversation

Projects
None yet
3 participants
@gaboraranyossy-da
Copy link
Contributor

commented Apr 30, 2019

  • fixed running until logic to handle gaps in offsets as well
  • refactored transaction pipeline for clarity

Pull Request Checklist

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@gaboraranyossy-da gaboraranyossy-da force-pushed the jumpover-fix branch from 3a8335c to 78c17b0 May 2, 2019

gaboraranyossy-da added some commits May 2, 2019

extracting pipeline logic
 Please enter the commit message for your changes. Lines starting

@gaboraranyossy-da gaboraranyossy-da force-pushed the jumpover-fix branch from 4149423 to 09552ff May 2, 2019

@gaboraranyossy-da gaboraranyossy-da marked this pull request as ready for review May 2, 2019

@gaboraranyossy-da gaboraranyossy-da requested review from bitonic and gerolf-da May 2, 2019

@gerolf-da
Copy link
Contributor

left a comment

missing copyright header.

@gaboraranyossy-da

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

thanks, fixed

Show resolved Hide resolved docs/source/support/release-notes.rst Outdated
@bitonic

bitonic approved these changes May 2, 2019

@gaboraranyossy-da gaboraranyossy-da merged commit c501d64 into master May 2, 2019

7 checks passed

Mergify — Summary 1 potential rule
Details
digital-asset.daml Build #20190502.56 succeeded
Details
digital-asset.daml (Linux) Linux succeeded
Details
digital-asset.daml (Windows) Windows succeeded
Details
digital-asset.daml (macOS) macOS succeeded
Details
digital-asset.daml (perf) perf succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@gaboraranyossy-da gaboraranyossy-da deleted the jumpover-fix branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.