Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing bug for mishandling potential offset gaps #802

Merged
merged 11 commits into from
May 2, 2019
Merged

fixing bug for mishandling potential offset gaps #802

merged 11 commits into from
May 2, 2019

Conversation

gabor-aranyossy
Copy link
Contributor

@gabor-aranyossy gabor-aranyossy commented Apr 30, 2019 •
edited
Loading

  • fixed running until logic to handle gaps in offsets as well
  • refactored transaction pipeline for clarity

Pull Request Checklist

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@gabor-aranyossy gabor-aranyossy added the component/ledger Sandbox and Ledger API label Apr 30, 2019
@gabor-aranyossy gabor-aranyossy added this to the Ledger SQL Backend milestone Apr 30, 2019
@gabor-aranyossy gabor-aranyossy marked this pull request as ready for review May 2, 2019 08:21
gerolf-da
gerolf-da approved these changes May 2, 2019
View reviewed changes
Copy link
Contributor

@gerolf-da gerolf-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing copyright header.

@gabor-aranyossy
Copy link
Contributor Author

thanks, fixed

bitonic
bitonic suggested changes May 2, 2019
View reviewed changes
docs/source/support/release-notes.rst Outdated Show resolved Hide resolved
@gabor-aranyossy gabor-aranyossy merged commit c501d64 into master May 2, 2019
@gabor-aranyossy gabor-aranyossy deleted the jumpover-fix branch May 2, 2019 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerolf-da gerolf-da gerolf-da approved these changes

@bitonic bitonic bitonic approved these changes

Assignees
No one assigned
Labels
component/ledger Sandbox and Ledger API
Projects
None yet
Milestone
Ledger SQL Backend
Development

Successfully merging this pull request may close these issues.
3 participants
@gabor-aranyossy @bitonic @gerolf-da