Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with the changing envelope period register faster than the envelope freqency #3

Closed
okaxaki opened this issue Oct 13, 2022 · 2 comments
Labels

Comments

@okaxaki
Copy link
Member

okaxaki commented Oct 13, 2022

The following vgm tweaks the envelope period register faster than the envelope frequency. emu2149 can not play it correcly.
This seems to be a degrade caused by the patch for issue #2 but essentially, this is due to the implementation of the period counter deviates from the actual chip. The similar problem might be occured with tone and noise period registers.

okaxaki added a commit that referenced this issue Oct 13, 2022
okaxaki added a commit that referenced this issue Oct 15, 2022
@okaxaki okaxaki closed this as completed Oct 15, 2022
@okaxaki okaxaki added the bug label Oct 15, 2022
@okaxaki okaxaki reopened this Oct 25, 2022
@okaxaki
Copy link
Member Author

okaxaki commented Oct 25, 2022

Currently fixed in the develop branch, will be released later.

okaxaki added a commit that referenced this issue Nov 1, 2022
…issue #3).

Fix the confusing PSG_setVolumeMode type argument.
Rename PSG_set_rate to PSG_setRate.
Rename PSG_set_quality to PSG_setQuality.
Restore PSG_setClock that was removed on v1.20 for compatibility.
Add PSG_setClockDivider function.
okaxaki added a commit that referenced this issue Nov 1, 2022
…issue #3).

Fix the confusing PSG_setVolumeMode type argument.
Rename PSG_set_rate to PSG_setRate.
Rename PSG_set_quality to PSG_setQuality.
Restore PSG_setClock that was removed on v1.20 for compatibility.
Add PSG_setClockDivider function.
okaxaki added a commit that referenced this issue Nov 24, 2022
…issue #3).

Fix the confusing PSG_setVolumeMode type argument.
Rename PSG_set_rate to PSG_setRate.
Rename PSG_set_quality to PSG_setQuality.
Restore PSG_setClock that was removed on v1.20 for compatibility.
Add PSG_setClockDivider function. (+1 squashed commit)
Squashed commits:
[5d2fe4e] Fix the bug with the changing period register faster than frequency (issue #3).
Fix the confusing PSG_setVolumeMode type argument.
Rename PSG_set_rate to PSG_setRate.
Rename PSG_set_quality to PSG_setQuality.
Restore PSG_setClock that was removed on v1.20 for compatibility.
Add PSG_setClockDivider function. (+1 squashed commit)
Squashed commits:
[5d2fe4e] Fix the bug with the changing period register faster than frequency (issue #3).
Fix the confusing PSG_setVolumeMode type argument.
Rename PSG_set_rate to PSG_setRate.
Rename PSG_set_quality to PSG_setQuality.
Restore PSG_setClock that was removed on v1.20 for compatibility.
Add PSG_setClockDivider function.
okaxaki added a commit that referenced this issue Nov 24, 2022
…issue #3).

Fix the confusing PSG_setVolumeMode type argument.
Rename PSG_set_rate to PSG_setRate.
Rename PSG_set_quality to PSG_setQuality.
Restore PSG_setClock that was removed on v1.20 for compatibility.
Add PSG_setClockDivider function.
@okaxaki
Copy link
Member Author

okaxaki commented Nov 24, 2022

Fixed at v1.40.

@okaxaki okaxaki closed this as completed Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant