Update dependencies and fix import. #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidlehn
force-pushed
the
update-dependencies
branch
from
28c024d
to
4ee5cec
Compare
It may have looked good... it was not. It didn't work in top-level apps that use bedrock-webpack due to a UMD bundle override. Removed that and webpack will now use ESM bundle in ESM apps. I don't think there is an issue with doing this in general these days. However, that override caused any |
dlongley
approved these changes
Oct 6, 2023
- Test with Node.js 20.x. - Update action verions.
- Update all dependencies. - Update quasar import to avoid errors due to no default export.
**BREAKING**: Remove `animate.css` `compat` override and use latest style. See the [migration guide](https://animate.style/#migration) for details on updating.
davidlehn
force-pushed
the
update-dependencies
branch
from
27458a3
to
edaa8c7
Compare
Using ESM vs UMD for Quasar means plugins are no longer used automatically or by default. Applications must be initialized with Quasar plugins it uses. This is currently not automatic and requires top-level application knowledge of all sub-modules in use and what plugins they require. The `quasarOptions` object added here can be used for this purpose and for other Quasar options.
|
@davidlehn We're running into issues with Quasar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.