revert session key; update hidden wallet #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasbakkum
force-pushed
the
180307/hiddenwallet
branch
from
e4c044b to
7adca05
Compare
douglasbakkum
force-pushed
the
180307/hiddenwallet
branch
from
7adca05 to
686246e
Compare
douglasbakkum
pushed a commit
that referenced
this pull request
Mar 12, 2018
686246e revert session key; update hidden wallet (djb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the hidden wallet process such that the hidden wallet is derived from the seed in the same way as the standard wallet. This gives an advantage that the hidden wallet can be recovered from the backup file (as a 'standard' wallet) using the hidden wallet password.
PR #192 (session key) was reverted to both reduce code complexity with this PR and because we plan to use a different method based on ECDH (for encrypted USB communication).