communication: added HMAC on encrypted messages to and from the BitBox #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Appending an HMAC on the encrypted messages to and from the BitBox. This should mitigate AES malleability on the first AES block since the encrypted content will now be checked for manipulation. Key derivation for the encryption and authentication key is performed on the shared secret derived from the device password.
douglasbakkum
approved these changes
Nov 29, 2018
douglasbakkum
added a commit
that referenced
this pull request
Nov 29, 2018
2374545 communication: added HMAC on encrypted messages to and from the BitBox (Stephanie Stroka)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appending an HMAC on the encrypted messages to and from the BitBox.
This should mitigate AES malleability on the first AES block since
the encrypted content will now be checked for manipulation.
Key derivation for the encryption and authentication key is performed on the
shared secret derived from the device password.