Skip to content

whitelist keypaths; require reset before reseeding #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2019
Merged

whitelist keypaths; require reset before reseeding #261

merged 1 commit into from
Feb 25, 2019

Conversation

douglasbakkum
Copy link
Member

  • xpub API: send back a warning and do not echo if using a non-whitelisted keypath in order to match keypaths supported by the mobile app.
  • Require reset before hardware wallet seed creation or recovery from backup. This matches what is already done in the desktop app.
  • astyle styling for previous commits

@douglasbakkum
xpub API: give warning and do not echo if non-whitelisted keypath; re…
907b125 
…quire reset before hww seed creation or recovery from backup
@douglasbakkum douglasbakkum merged commit 907b125 into BitBoxSwiss:master Feb 25, 2019
douglasbakkum added a commit that referenced this pull request Feb 25, 2019
@douglasbakkum
Merge pull request #261
f9b0e12 
907b125 xpub API: give warning and do not echo if non-whitelisted keypath; require reset before hww seed creation or recovery from backup (djb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@douglasbakkum