update u2f hijack whitelist for vintage MEW and latest Chrome #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasbakkum
force-pushed
the
190227/u2fhijack_appid
branch
from
4bdbdb8 to
1795622
Compare
douglasbakkum
added a commit
that referenced
this pull request
Mar 4, 2019
1795622 update u2f hijack whitelist for vintage MEW and latest Chrome (djb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MyEtherWallet redid their website and put the old version of MEW at vintage.myetherwallet.com.
In addition, the 'hijack code' was changed from the U2F
challengeparameter to theappIdparameter, as the latter is a more stable representation of the website origin (for anti-phishing purposes). This was made apparent as the latest Chrome version changed how thechallengeparameter was computed.