Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1416: Tests for the user import endpoint #1552

Merged
merged 4 commits into from
Jul 31, 2024
Merged

1416: Tests for the user import endpoint #1552

merged 4 commits into from
Jul 31, 2024

Conversation

seluianova
Copy link
Contributor

@seluianova seluianova commented Jul 29, 2024 •
edited
Loading

Short description

Add integration tests for user import endpoint.
Blocked by #1536

Proposed changes

  • implement UserImportTest

Side effects

Shouldn't be any

Resolved issues

Fixes: #1532

@seluianova seluianova marked this pull request as ready for review July 29, 2024 16:33
@seluianova seluianova changed the title 1416: Backend integration tests 1416: Tests for the user import endpoint Jul 29, 2024
f1sh1918
f1sh1918 reviewed Jul 30, 2024
View reviewed changes
Copy link
Contributor

@f1sh1918 f1sh1918 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍
I think the test, that the startDate cannot be after endDate is missing.

Base automatically changed from 1318-setup-backend-test-database to main July 31, 2024 10:21
@seluianova
Copy link
Contributor Author

seluianova commented Jul 31, 2024 •
edited
Loading

Added the missed test.
@f1sh1918 pls review again, your approval has been reset

Upd. wait, there is something suddenly failing

f1sh1918
f1sh1918 approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@f1sh1918 f1sh1918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go just resolve the check issues in circle ci

@seluianova seluianova merged commit c887b58 into main Jul 31, 2024
1 check passed
@seluianova seluianova deleted the 1416-backend-integration-tests branch July 31, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f1sh1918 f1sh1918 f1sh1918 approved these changes

@steffenkleinle steffenkleinle Awaiting requested review from steffenkleinle steffenkleinle is a code owner

@ztefanie ztefanie Awaiting requested review from ztefanie ztefanie is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add integration tests for backend
2 participants
@seluianova @f1sh1918