-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ImprintPage model #357
Comments
I made a test by creating to test-models one "Oberklasse" and one "Unterklasse" where Unterklasse inherits from Oberklasse. So, to keep the behaviour that "Page.objects.all()" only returns the "content pages" (not the disclaimer page) we would need something like a "GeneralPage" which is inherited from Page. Analog thing with PageTranslation. Under these circumstances I find it more sensible to create a DisclaimerTranslation-model with the attributes |
Does the disclaimer page and its translations have the same translation workflow like the normal pages? Do we also keep older versions? |
Oh sorry, it seems that I should have done better research before proposing this. I found a few ways how to achieve the desired behaviour with a custom model manager, but this is kind of hacky and not worth the drawbacks I think. So yes, probably it's best to define these as standalone classes... if we use an abstract base class for the content in the future, we can make our optimizations there. And yes, I'd propose to use the same versioning and translation system as for pages, including all special fields. |
One other option would be to define an |
- Add AbstractBasePage for attributes and methods shared with other page types - Keep tree-related attributes and methods in the page model (Prerequisite for #357)
- Add AbstractBasePageTranslation for attributes and methods shared with other page translation types - Keep tree- and revision-related attributes and methods in the page translation model (Prerequisite for #357)
- Add AbstractBasePage for attributes and methods shared with other page types - Keep tree-related attributes and methods in the page model (Prerequisite for #357)
- Add AbstractBasePageTranslation for attributes and methods shared with other page translation types - Keep tree- and revision-related attributes and methods in the page translation model (Prerequisite for #357)
Add an
Imprint
andImprintTranslation
model which should be similar toPage
andPageTranslation
.The text was updated successfully, but these errors were encountered: