Deploy fixed region cloning, FCM messages, page form & translation status #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
svenseeberg
commented
Mar 4, 2022
•
svenseeberg
commented
- [ #1086 ] Provide correct URL for POI
- [ #1247 ] Update translation status on source status changes
- [ #1251 ] Fix change detection in page form
- [ #1260 ] Fix Firebase messaging
- [ #1259 ] Fix cloning of regions
Deliver correct link to poi form
Co-authored-by: Timo Ludwig <ludwig@integreat-app.de> Co-authored-by: Giuliano Mele <mele@integreat-app.de>
…n-status Update translation status on source status changes
…etection Fix page form change detection
* Select FCM test region by slug and not id. * Support legacy FCM API UR
Fix Firebase Notifications
timobrembeck
previously approved these changes
Mar 4, 2022
|
This is ready to deploy I think, we just have to keep in mind that it introduces one new bug (#1257) which should be fixed asap afterwards. |
|
We should merge #1263 and include it in this release if we can do that before Monday. |
- Add test case which fails in the current state to reproduce #1259 - Order translation models by language to keep deterministic order to compare querysets
- Commit f708ba1 only handled the page tree, not the language tree - Make test case added in the previous commit succeed - Add unnecessarily beautiful logging output
Fix cloning regions
Add FCM API tests
On the current state, this test fails.
- coerce ref_node field to int was not possible because the reference to no node cannot be expressed by an integer - Use strings for values of ref_node fields where possible - Fix parent field after move() and not before save() because it caused problems for language tree nodes
Under normal circumstances, this should not happen. But when the default language is changed into a language that does not have a translation for each page, this might lead to problems.
…ee-node Fix creating language tree nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.