Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds student attendances to show page #260

Merged
merged 3 commits into from
Oct 5, 2017

Conversation

ghatighorias
Copy link
Contributor

This PR give the student show page an overview of her attendance to all classes grouped by terms

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 86.265% when pulling 5af6529 on ghatighorias/add_student_attendances_to_show_page into 40b4800 on master.

@ghatighorias ghatighorias temporarily deployed to staging-olive-app October 4, 2017 12:14 Inactive
@ghatighorias ghatighorias temporarily deployed to staging-olive-app October 4, 2017 12:38 Inactive
@ghatighorias
Copy link
Contributor Author

Where condition is changed to user student from attendance. the reason is that a class has many attendance and filtering based on offered_course.student_id does not mean that the correct attendance is loaded too. it just mean the first attendance is loaded

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 86.265% when pulling ace597e on ghatighorias/add_student_attendances_to_show_page into 40b4800 on master.

@rhnonose rhnonose changed the base branch from master to develop October 5, 2017 20:58
@rhnonose rhnonose merged commit 5e51183 into develop Oct 5, 2017
@rhnonose rhnonose deleted the ghatighorias/add_student_attendances_to_show_page branch October 16, 2017 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants