-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Persian translation #466
Conversation
👀 Thanks for doing this, I'll put this on my list to review! One immediate thing -- for all the files you've added/updated, please can you make sure the copyright year in the file header is 2024? |
Ah, and as the CI failure suggests, you'll need to add the |
I have modified copyright year and added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally this looks great, though there are a few strings that I'm wondering if they should be translated rather than being English still?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tyvm for working on this 💙
Type of Change
Add persian translate
What should this PR do?
What are the acceptance criteria?
This is just translation so it can not break the app