Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Persian translation #466

Merged
merged 3 commits into from
Feb 24, 2024
Merged

Add Persian translation #466

merged 3 commits into from
Feb 24, 2024

Conversation

KasraK2K
Copy link
Contributor

Type of Change

Add persian translate

What should this PR do?

What are the acceptance criteria?

This is just translation so it can not break the app

@MattIPv4
Copy link
Contributor

👀 Thanks for doing this, I'll put this on my list to review! One immediate thing -- for all the files you've added/updated, please can you make sure the copyright year in the file header is 2024?

@MattIPv4
Copy link
Contributor

Ah, and as the CI failure suggests, you'll need to add the fa key to all the other language packs :)

@KasraK2K
Copy link
Contributor Author

I have modified copyright year and added fa into all other languages.

@MattIPv4 MattIPv4 self-requested a review February 19, 2024 17:22
@MattIPv4 MattIPv4 changed the title add persian language Add Persian translation Feb 19, 2024
Copy link
Contributor

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally this looks great, though there are a few strings that I'm wondering if they should be translated rather than being English still?

src/nginxconfig/i18n/fa/common.js Outdated Show resolved Hide resolved
src/nginxconfig/i18n/fa/common.js Outdated Show resolved Hide resolved
Copy link
Contributor

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm for working on this 💙

@MattIPv4 MattIPv4 merged commit 23c40c0 into digitalocean:master Feb 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants