-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update autorest.python to 6.13.16 #293
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danaelhe
commented
May 15, 2024
danaelhe
commented
May 15, 2024
danaelhe
commented
May 15, 2024
andrewsomething
previously approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 LGTM!
Here's the full changelog for anyone interested:
andrewsomething
changed the title
Update Autorest to 6.13.16
Update autorest.python to 6.13.16
May 23, 2024
andrewsomething
approved these changes
May 28, 2024
danaelhe
added a commit
that referenced
this pull request
May 28, 2024
- #293 - @danaelhe - Update autorest.python to 6.13.16 - #294 - @digitalocean-engineering - [bot] APPS-8732 - Add OpenSearch Log Forwarding destination.: Re-Generated From digitalocean/openapi@8ce96ef
Merged
danaelhe
added a commit
that referenced
this pull request
May 28, 2024
- #293 - @danaelhe - Update autorest.python to 6.13.16 - #294 - @digitalocean-engineering - [bot] APPS-8732 - Add OpenSearch Log Forwarding destination.: Re-Generated From digitalocean/openapi@8ce96ef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #290
Was able to reproduce the issue described in #290 with docstring errors with python 3.12:
Thanks to @onlined who let us know this was fixed in
autorest 6.13.16
Updated the autorest version to 6.13.16 and ran
make generate
Had to also update the python version in
pyproject.toml
to^3.9.0
[tool.poetry.dependencies]
to fix the issue- Installing frozenlist (1.3.3): Failed
when runningpoetry install
.It's probably due time to update to a newer version of autorest.