Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update autorest.python to 6.13.16 #293

Merged
merged 8 commits into from
May 28, 2024
Merged

Update autorest.python to 6.13.16 #293

merged 8 commits into from
May 28, 2024

Conversation

danaelhe
Copy link
Member

@danaelhe danaelhe commented May 14, 2024

Addresses #290

Was able to reproduce the issue described in #290 with docstring errors with python 3.12:

make generate
.....
<unknown>:34822: SyntaxWarning: invalid escape sequence '\ '
<unknown>:42159: SyntaxWarning: invalid escape sequence '\ '
<unknown>:48460: SyntaxWarning: invalid escape sequence '\ '
<unknown>:63275: SyntaxWarning: invalid escape sequence '\ '
<unknown>:63370: SyntaxWarning: invalid escape sequence '\ '
<unknown>:75107: SyntaxWarning: invalid escape sequence '\ '

Thanks to @onlined who let us know this was fixed in autorest 6.13.16

Updated the autorest version to 6.13.16 and ran make generate

Had to also update the python version in pyproject.toml to ^3.9.0 [tool.poetry.dependencies] to fix the issue - Installing frozenlist (1.3.3): Failed when running poetry install.

It's probably due time to update to a newer version of autorest.

Makefile Show resolved Hide resolved
@danaelhe danaelhe requested a review from a team May 15, 2024 14:38
pyproject.toml Outdated Show resolved Hide resolved
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewsomething andrewsomething changed the title Update Autorest to 6.13.16 Update autorest.python to 6.13.16 May 23, 2024
@danaelhe danaelhe merged commit 9912278 into main May 28, 2024
5 checks passed
@danaelhe danaelhe deleted the update_autorest branch May 28, 2024 20:33
danaelhe added a commit that referenced this pull request May 28, 2024
- #293 - @danaelhe - Update autorest.python to 6.13.16
- #294 - @digitalocean-engineering - [bot] APPS-8732 - Add OpenSearch Log Forwarding destination.: Re-Generated From digitalocean/openapi@8ce96ef
@danaelhe danaelhe mentioned this pull request May 28, 2024
danaelhe added a commit that referenced this pull request May 28, 2024
- #293 - @danaelhe - Update autorest.python to 6.13.16
- #294 - @digitalocean-engineering - [bot] APPS-8732 - Add OpenSearch Log Forwarding destination.: Re-Generated From digitalocean/openapi@8ce96ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants