This repository has been archived by the owner on Feb 21, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Accessibility Review #1
Comments
Thanks Sami! Will fix those things as soon as I get some spare time. I was sure there was some little things left to do. :) |
ronilaukkarinen
pushed a commit
that referenced
this issue
Nov 16, 2017
ronilaukkarinen
pushed a commit
that referenced
this issue
Nov 16, 2017
ronilaukkarinen
pushed a commit
that referenced
this issue
Nov 16, 2017
ronilaukkarinen
pushed a commit
that referenced
this issue
Nov 16, 2017
ronilaukkarinen
pushed a commit
that referenced
this issue
Nov 16, 2017
ronilaukkarinen
pushed a commit
that referenced
this issue
Nov 16, 2017
ronilaukkarinen
pushed a commit
that referenced
this issue
Nov 16, 2017
ronilaukkarinen
pushed a commit
that referenced
this issue
Nov 16, 2017
ronilaukkarinen
pushed a commit
that referenced
this issue
Nov 16, 2017
ronilaukkarinen
pushed a commit
that referenced
this issue
Nov 16, 2017
ronilaukkarinen
pushed a commit
that referenced
this issue
Nov 16, 2017
ronilaukkarinen
pushed a commit
that referenced
this issue
Nov 16, 2017
ronilaukkarinen
pushed a commit
that referenced
this issue
Nov 16, 2017
ronilaukkarinen
pushed a commit
that referenced
this issue
Nov 16, 2017
ronilaukkarinen
pushed a commit
that referenced
this issue
Nov 16, 2017
These are now fixed, and more. Tested with WAVE by webaim, Alix and tota11y. Contacted Crisp chat about their service, that code I cannot touch myself. Thanks a lot Sami for your effort! Nowadays I'm concentrating a11y way more than at the time when doing this website. Better and better daily tools help a lot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Broken is a promise! Here we go.
Keyboard Navigation
Avaa chat
focus is hard to see. I'd add one more pixel ofbox-shadow
. Also note that color change on focus need to meet 4.5 contrast rule. On header background image that might be a problem.Esc
should close it and bring focus back toAvaa chat
menu item.<span>
which doesn't have any a11y tools like keyboard focus build in.display: none
orvisibility: hidden
CSS.Enter
. I'd like to pressEnter
again and it would close the menu.Alaspäinkin pääsee
doesn't have focus styles.Controls
Skip Links
Forms
Headings
h3
so that heading levels won't skip.date
ish5
and author name ish4
. At leasth5
should beh4
(skipping one heading level). I'd personally not use heading at all in those fields. It doesn't feel semantically correct.h3
.h2
.ARIA Landmark Roles
Link Text
<a href="https://www.dude.fi/tyot/jylkkari" class="permalink"></a>
. Depending on AT it announces something, for example Voiceover reads the end of the slug.aria-label="Title of the post"
but I try to avoid empty links because it's not semantically correct. Therefore I usescreen-reader-text
class inside link in these cases.title
should be avoided because some AT software doesn't announce that all.Contrasts
Images
aria-hidden="true"
just in case that AT software doesn't try to announce something.Screen Reader Text
The text was updated successfully, but these errors were encountered: