Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/aws 2.3 #26

Closed
wants to merge 31 commits into from
Closed

Feature/aws 2.3 #26

wants to merge 31 commits into from

Conversation

jufemaiz
Copy link
Collaborator

@jufemaiz jufemaiz commented Jul 9, 2016

Right, so, long time no speak. With Tour de France happening and awaiting the arrival of my first child I've had some time to review this.

There has been major changes to the AWS SDK Gem that I've now adopted for this one.

Major Changes

  • Further, code has been moved out of individual bin files and into a more structured Whenever::Elasticbeanstalk class. This has reduced duplication considerably.
  • By default, AWS EC2 Instance Credentials are passed as the credentials to use for checking tags etc.
  • Roles now include the traditional leader/non-leader in addition to the environmental from RACK_ENV environmental variable.

I've got this working on a staging environment but would like to get some feedback, particularly from @dignoe and @CyborgMaster due to their work.

@dignoe
Copy link
Owner

dignoe commented Jul 11, 2016

I haven't used this gem in years (I've moved to using OpsWorks), so I don't feel that I can add much to this conversation. Please let me know if you need anything though (like github or rubygem permissions), and I'd be happy to help.

@CyborgMaster
Copy link

@jufemaiz, I really like the approach you've taken here. Seems like the refactoring is going in a good direction. I can't say wether it works correctly because the only real way to test it is to run in inside elastic beanstalk in a real instance, but assume it works, I'm all for it.

@binodmainali
Copy link

I can actually test this out, as I am have one spare Beanstalk instance running for testing. I have commented on an issue. @jufemaiz may be we can get in touch and figure out something

@jufemaiz
Copy link
Collaborator Author

@binodmainali1 note the requirements to work with git based gems.

@dignoe
Copy link
Owner

dignoe commented Jul 19, 2016

@jufemaiz It looks like you have access on Rubygems to update the packaged gem.

@jufemaiz
Copy link
Collaborator Author

@dignoe yep, just wasn't really wanting to push something there without a bit of a review.

For those wanting to test, have a read of https://gist.github.com/jufemaiz/eba1ee62c3709d2db90cc16eb2c5c10b

@jufemaiz
Copy link
Collaborator Author

Right I think I'm at a stage to make this a v2.0.0-beta0 release.

Any objections?

@Drakula2k
Copy link

Drakula2k commented Aug 11, 2016

Hi!

I just tested it with 64bit Amazon Linux 2016.03 v2.1.3 running Ruby 2.3 (Puma) and webapp user's cron gives error (CRON) ERROR chdir failed (/home/webapp): No such file or directory on run (on /var/log/cron log).

I investigated it a bit and seems that cron needs user's home directory for internal needs, so I think the easiest workaround is to create it and give access to webapp user.

Also something weird happened to logs, there is a symlinks loop:

# ll /var/app/containerfiles/logs/production.log
lrwxrwxrwx 1 webapp webapp 35 Aug 11 13:32 /var/app/containerfiles/logs/production.log -> /var/app/current/log/production.log

#ll /var/app/current/log/development.log
lrwxrwxrwx 1 webapp webapp 36 Aug 11 13:32 /var/app/current/log/development.log -> /var/app/current/log/development.log

Seems related to config from Rails + GIT gist.

@jwilsjustin
Copy link

@jufemaiz Still thinking about a v2.0.0-beta0 release on rubygems.org?

@jufemaiz
Copy link
Collaborator Author

Closing this out.

Happy to consider re-opening if people are interested.

I'll write up a better approach to this using Docker and ECS / Fargate if people show interest.

@jufemaiz jufemaiz closed this Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants