Feature/data source instance #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added test coverage
- added corresponding test coverage
- createTerraformProviderDataSourceInstanceMap only registers as data source instances the openAPIResources that are terraform resource compatible
…and data source instance - since createTerraformProviderResourceMap was already looping through the terraform compatible resources and considering the data source instance is only registered from already deemed terraform compatible resources, reusing the logic and returning both maps in one go
- this prevents errors where when converting the property to computed some swagger properties had a default value which terraform does not allow.
|
till now it looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Please add as many details as possible about the change here. Does this Pull Request resolve any open issue? If so, please make sure to link to that issue:
Fixes: #154
Type of change
What type of change does your code introduce to the provider? Please put an
x(w/o heading/trailing white spaces)in the boxes that apply:
Checklist
Please put an
x(w/o heading/trailing white spaces) in the boxes that apply: