Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push code cov report from ci build too #167

Merged
merged 4 commits into from
Oct 16, 2019
Merged

push code cov report from ci build too #167

merged 4 commits into from
Oct 16, 2019

Conversation

dikhan
Copy link
Owner

@dikhan dikhan commented Oct 15, 2019

Proposed changes

Please add as many details as possible about the change here. Does this Pull Request resolve any open issue? If so, please make sure to link to that issue:

Push code coverage report on CI builds

Type of change

What type of change does your code introduce to the provider? Please put an x (w/o heading/trailing white spaces)
in the boxes that apply:

  • Bug-fix (change that fixes current functionality)
  • New feature (change that adds new functionality)

Checklist

Please put an x (w/o heading/trailing white spaces) in the boxes that apply:

  • I have read and followed the CONTRIBUTING guidelines
  • I have made sure code compiles correctly
  • I have run 'make test' locally from the terraform_provider_api folder and no errors were found
  • I have added tests that prove my fix is effective or that my feature works
  • I have added/updated necessary documentation (if appropriate)

Copy link
Collaborator

@lillchan lillchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #167 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   88.92%   88.95%   +0.03%     
==========================================
  Files          51       51              
  Lines        3042     3042              
==========================================
+ Hits         2705     2706       +1     
- Misses        215      217       +2     
+ Partials      122      119       -3
Impacted Files Coverage Δ
openapi/plugin_config.go 71.83% <0%> (+1.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efc30f2...41c0da0. Read the comment docs.

@dikhan dikhan merged commit 5950901 into master Oct 16, 2019
@dikhan dikhan deleted the making-repo-awesome branch October 16, 2019 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants