-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(main): Add new guidelines #5
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add theme data to globals.css - Update WebLinks into class - Add SiteInfo class to config - Add custom screen sizes - Add NavBar views - Add IconClose and IconMenu - Add SocialMediaBar
- Create NavBar pages (About, Education, Experience, Media, Connect) - Add layouts for each page - Update home page - Add custom themes to globals.css - Add scrollbar theme - Change seperate fontStyle.ts config file
This is concerned only with learning better data structure and organization practices in TS. (π Could be changed in the future.)
- Update layout paddings into main - Create common components (ItemCards & SectionTitle) - Add Instagram for links - Reduce repetition lines in pages - Add ring to cards - Add interfaces into types directory - Add welcome GET api - Update folder structure
- Create CHANGELOG.md - Update README.md
e.g., - Remove export function IntroductionCard() { - Add const IntroductionCard = () => {
feat(dev): Develop Version 1.0.0
- Ensure proper list structure for navigation links on both desktop and mobile views. - Remove unnecessary list item wrappers around Link components for better screen reader compatibility.
- Add BRANCH_NAMING_GUIDELINES.md - Add PULL_REQUEST_GUIDELINES.md - Update new README.md - Add Resend key add - Update CHANGELOG.md
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π Description:
Added guidelines for branches and pull requests, updated README with Resend key info, and documented changes in CHANGELOG.
β Related Issue:
None
π» Changes Made:
πΈ Screenshots:
None
π§ͺ Testing:
Documentation with markdown style
β By submitting this pull request, I confirm that my contributions are made under the terms of the project's license and that I have read and understood the code of conduct.