Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't alias __typename #121

Merged
merged 4 commits into from
Apr 17, 2019

Conversation

aaronwhite
Copy link
Contributor

This fixes issue #120 by selectively modifying the alias function to not alias __typename. There may be a better way to tackle the issue, but this works in my case as is.

@dillonkearns
Copy link
Owner

Thank you Aaron!

I moved the logic for skipping the alias for __typename into the maybeAliasHash since that's where the other logic lives for deciding whether or not to use an alias.

I also changed it to return Nothing instead of Just "__typename" so that it uses no alias instead of an alias like __typename: __typename.

I think it's good to go now!

@aaronwhite
Copy link
Contributor Author

Makes sense & thank you for cleaning it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants