Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch discardParsedErrorData from returning a () to an unconstrained a #245

Merged
merged 1 commit into from
Dec 16, 2019

Conversation

Jayshua
Copy link
Collaborator

@Jayshua Jayshua commented Nov 18, 2019

As discussed in #224

@Jayshua
Copy link
Collaborator Author

Jayshua commented Nov 18, 2019

Turned out it didn't even need the never call at all. 🤷‍♂

@dillonkearns
Copy link
Owner

Wow, that's nice and simple then. Thanks for this nice refinement 👍

I don't have access to a computer for a couple of weeks. I just gave you push access, though, so you can merge it and do an Elm package release (since Elm let's you publish if you can create a git tag). If you do a release, would you mind updating the Elm package release notes markdown file, too?

@Jayshua
Copy link
Collaborator Author

Jayshua commented Nov 19, 2019

I'm happy to try stumbling through it :) Never published an Elm package before, so I'll have to look up how its done. Shall report back when I get a chance to work through it.

@dillonkearns dillonkearns merged commit d6474c0 into dillonkearns:master Dec 16, 2019
@dillonkearns
Copy link
Owner

I published this in the latest release! https://github.com/dillonkearns/elm-graphql/blob/master/CHANGELOG-ELM-PACKAGE.md#500---2019-12-16

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants