Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graphql-request to v3.3.0 #419

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Update graphql-request to v3.3.0 #419

merged 1 commit into from
Nov 11, 2020

Conversation

Hermanverschooten
Copy link
Contributor

To resolve the vulnerability mentioned in #399, it suffices to upgrade graphql-request to the latest version.
To be sure it did not break anything, I tried these public graphql sites, both with the original version and the updated version, then diff-ed the results and there were none. So I am pretty sure this should cause no issues.

https://pristine-gadget-267405.appspot.com/graphql/
https://api.graphql.jobs/
http://api.catalysis-hub.org/graphql
https://countries.trevorblades.com
https://bahnql.herokuapp.com/graphql
https://api.digitransit.fi/routing/v1/routers/finland/index/graphql
https://portal.ehri-project.eu/api/graphql

@Hermanverschooten Hermanverschooten changed the title Update graphql-reqeuest to v3.3.0 Update graphql-request to v3.3.0 Nov 11, 2020
@dillonkearns dillonkearns merged commit 67614cf into dillonkearns:master Nov 11, 2020
@dillonkearns
Copy link
Owner

That's perfect, thanks for taking the time to test that out @Hermanverschooten!

@Hermanverschooten Hermanverschooten deleted the update_graphql-request branch November 11, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants