Use Cli.Validate.regexWithMessage when validating module name #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display validation message with an additional "I expected this to be" so the output becomes: ´´´ Validation errors: Invalid `--scalar-codecs` option. I expected this to be matching "^[A-Z][A-Za-z_]*(\.[A-Z][A-Za-z_]*)*$", but got 'src/CustomScalarCodecs' ´´´
|
Hello @ZeldaIV, thanks so much for the PRs! I made a suggestion to tweak the message a little, what do you think? I was thinking mentioning that it's expecting an "Elm module name" explicitly could give a clearer hint of what that Regex means. If you agree, you can accept the suggestion and it will commit it. Thank you! |
Co-authored-by: Dillon Kearns <dillon@incrementalelm.com>
|
Sure, nice to be of assistance. I accepted your suggestion. |
|
This is now live in version 4.2.3 of the NPM package 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display validation message with an additional "I expected this to be" so the output becomes: