Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatted inline strings support #260

Merged
merged 1 commit into from Jul 31, 2023
Merged

Add formatted inline strings support #260

merged 1 commit into from Jul 31, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jun 6, 2023

There is an issue with formatted inline strings.

Cell xml:

<c s="1" t="inlineStr" r="A1">
  <is>
    <r>
      <t>Regular </t>
    </r>
    <r>
      <rPr>
        <b/>
      </rPr>
      <t>Bold</t>
    </r>
  </is>
</c>

Expected csv value: Regular Bold
Actual csv value: Regular

The proposed PR fixes this behavior.
I've added a test for this case and make sure all the other tests pass.

@dilshod dilshod merged commit c238a2d into dilshod:master Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant