Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable back button on connect activity #2720

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Enable back button on connect activity #2720

merged 2 commits into from
Oct 5, 2023

Conversation

shubham1g5
Copy link
Contributor

Summary

Shows back button on Connect Workflow Screens plus Home Screen for Connect Launches

Safety Assurance

  • If the PR is high risk, "High Risk" label is set
  • I have confidence that this PR will not introduce a regression for the reasons below
  • Do we need to enhance manual QA test coverage ? If yes, "QA Note" label is set correctly

Automated test coverage

None

Safety story

Home Screen uses the connect launch flag to enable the back screen button to not affect normal CC workflow, other changes are limited to connect

@shubham1g5 shubham1g5 changed the base branch from master to dv/connect_initial October 5, 2023 20:09
@shubham1g5 shubham1g5 added the skip-integration-tests Skip android tests. label Oct 5, 2023
@shubham1g5 shubham1g5 merged commit 41d5b1f into dv/connect_initial Oct 5, 2023
3 of 8 checks passed
@shubham1g5 shubham1g5 deleted the enableBackOnConnect branch October 5, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrangeAndGreen OrangeAndGreen OrangeAndGreen approved these changes

Assignees
No one assigned
Labels
skip-integration-tests Skip android tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shubham1g5 @OrangeAndGreen