Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update android_translatable_strings.txt #2735

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Update android_translatable_strings.txt #2735

merged 1 commit into from
Dec 7, 2023

Conversation

orangejenny
Copy link
Contributor

@orangejenny orangejenny mentioned this pull request Dec 7, 2023
Closed
@shubham1g5
Copy link
Contributor

@damagatchi retest this please

@orangejenny
Copy link
Contributor Author

I'm going to merge without fixing the lint errors, though I do appreciate the reminder that it's "Wi-Fi" not "Wi-fi".

@shubham1g5 This will add this string to the default set of translations when users bulk download CCUI translations, right?

@orangejenny orangejenny merged commit 9119e74 into master Dec 7, 2023
2 of 4 checks passed
@orangejenny orangejenny deleted the orangejenny-patch-2 branch December 7, 2023 18:09
@shubham1g5
Copy link
Contributor

Right, this basically makes sure that the translation make it in https://github.com/dimagi/commcare-translations/ for all future releases which in turn updates the CCUi translations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham1g5 shubham1g5 shubham1g5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orangejenny @shubham1g5