Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use stderr instead of stdout for error messages #137

Merged
merged 2 commits into from
May 19, 2020
Merged

Conversation

czue
Copy link
Member

@czue czue commented May 19, 2020

This makes it easier to programatically access these (which is used by commcare sync)

Copy link
Member

@ctsims ctsims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a strong change to me.

nit: I have 0 horses in this race, but I think the 'pythonic' way to print to stderr is print("message", file=sys.stderr) Not sure if the HQ team has an explicit preference.

@czue
Copy link
Member Author

czue commented May 19, 2020

I think the 'pythonic' way to print to stderr is print("message", file=sys.stderr)

I had just copied it from elsewhere in the file but that does seem better. let me test/update

Copy link
Contributor

@millerdev millerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree on print(..., file=sys.stderr)

@czue
Copy link
Member Author

czue commented May 19, 2020

updated @millerdev @ctsims

@czue czue merged commit 74ef2a4 into master May 19, 2020
@czue czue deleted the cz/log-to-stderr branch May 19, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants