WIP: Using 'real' joins instead of extra_tables and filters. #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My use case requires an outer join, which isn't possible with the current methods.
This PR is more to open a discussion. I've found at least one bug with my approach, and I did this with less of an understanding of the Query object, and more shotgun debugging.
My main problem right now is that some of the table names aren't properly mapped to aliases. I'll try to generate a minimal test case that triggers it once I track down why it's happening.