Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OuterRef resolution in CTE subquery #16

Closed
wants to merge 2 commits into from
Closed

Fix OuterRef resolution in CTE subquery #16

wants to merge 2 commits into from

Conversation

SebCorbin
Copy link
Contributor

No description provided.

@SebCorbin SebCorbin mentioned this pull request Apr 17, 2020
Closed
@SebCorbin SebCorbin changed the title Add test for OuterRef usage in CTE Fix OuterRef resolution in CTE subquery Apr 20, 2020
@SebCorbin
Copy link
Contributor Author

@millerdev Hey, I tackled this problem by implementing a CTESubquery class that also resolve expressions in _with_cte

@millerdev
Copy link
Contributor

Thanks for your contribution @SebCorbin. I will try to find some time to review it soon.

@millerdev millerdev mentioned this pull request Apr 24, 2020
Merged
@millerdev
Copy link
Contributor

@SebCorbin I would prefer not to add another public CTE* class if possible. I found a way to get around that in #19. However, the effort you put into this was very helpful. Thank you!

@millerdev millerdev closed this Apr 24, 2020
@SebCorbin
Copy link
Contributor Author

Nice, that’s an even better solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SebCorbin @millerdev