Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get_column #18

Merged
merged 3 commits into from
Nov 3, 2015
Merged

Fix get_column #18

merged 3 commits into from
Nov 3, 2015

Conversation

nickpell
Copy link
Contributor

@nickpell nickpell commented Nov 2, 2015

@nickpell
Copy link
Contributor Author

nickpell commented Nov 2, 2015

@snopoke @czue cc: @calellowitz

@nickpell nickpell mentioned this pull request Nov 2, 2015
Merged
@czue
Copy link
Member

czue commented Nov 3, 2015

👍 from me

snopoke
snopoke reviewed Nov 3, 2015
View reviewed changes
tests/test_filters.py
@@ -18,8 +18,7 @@ class MockTable(object):
class MockColumns(object):
pass
cls.mock_table = MockTable()
setattr(cls.mock_table, 'c', MockColumns())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove the MockColumns class?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the catch - #19

snopoke added a commit that referenced this pull request Nov 3, 2015
@snopoke
Merge pull request #18 from dimagi/fix-get_column
08dd89b 
Fix get_column
@snopoke snopoke merged commit 08dd89b into master Nov 3, 2015
@snopoke snopoke deleted the fix-get_column branch November 3, 2015 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickpell @czue @snopoke