changed to setuptools and replaced cStringIO

[klintan]

Changes to adapt to Python 3. Changed to setuptools (as also seen in another open PR).

Needed to make some changes to get all the tests to pass, but now all passes. Will add some additional tests for pdutil but will keep them in a separate PR.

[dimatura]

Great, thanks! I'll check it out. Would it still work on 2.7?

[klintan]

As its stands right no, it would not. For instance .iteritems() changed to .items() in python3. Some other minor things right now that would not work in python2.7 but those are the major things I think.
I'll take a look and see if I can get it compatible.

[klintan]

Ok the tests passes now on python 2 as well, so I think it should be compatible with both now. Take a look and let me know what you think. :)

[dimatura]

Nice! I'll give it a try!

[klintan]

@dimatura have you had time testing it out on python 2 ? :)

[Qiang-Xu]

Nice @klintan, thanks.(Actually I did exactly the same thing on my machine :~))

[AlexandreSi]

Hi all,
@dimatura, do you consider merging @klintan's PR?

[ir0nt0ad]

@dimatura any chance for a merge? thanks

[themightyoarfish]

Please, please please merge this!

[hhansen-bdai]

It would be great if this could be merged!

[kentaroy47]

👀

[clydecbrown]

I chatted with @dimatura a bit. It sounds like he is willing to keep this project moving but not necessarily to maintain it himself. There are some viable forks out there. The @DanielPollithy fork brings in the @klintan changes plus some additional clean-up. Some questions for everyone:

• Which fork to use?
• Keep using a personal repo or move to a shared repo?
• Who will volunteer for maintenance duty?
• Can we publish new versions to the existing pypi release? (@dimatura has the key)

For my part, I'm using the @klintan fork. That works but the @DanielPollithy fork looks like an improvement. I can volunteer as a maintainer if no one else wants it, though we are better off with two maintainers. Ideally we would get a couple people with access keys to push a release to pypi.

[DanielPollithy]

Hi @clydecbrown !
I think it's a good idea.

In order to get a better overview for the discussion, I will try to summarize what my fork contains:

• the klintan PR "fixed py2 compatibility"
• the PR: "Type mapping ('I', 1) as np.int8 added"
• a tox config to test py2 and py3 (and the tests are running on travis)
• the docs hosted at readthedocs: https://pypcd-clone.readthedocs.io/en/latest/readme/
• three very simple notebooks to demonstrate the usage, e.g. https://github.com/DanielPollithy/pypcd/blob/master/examples/notebooks/02_Load_Pointcloud_with_colors.ipynb
• rubenvanparys's changes: handle pointcloud with only one point, ...
• support for StringIO and BytesIO (just check which one can be imported)

[clydecbrown]

Seems like we should go with the @DanielPollithy fork since he is putting in the most effort, and make that one the official fork for release. @dimatura what do you think–willing to hand over the pypi token?