Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible approach to restoring sanity on the interface and returning strings as
&str
.Per c-ares/c-ares#769
it's clearly desirable to return strings as
&str
on the rust bindings, but how to deal with the possibility that we are using an old c-ares that has not checked that this is true?the approach here is: make use of rust's checking, and just fall over -
unwrap()
- if we receive a string that is not valid. The justification for that being something like:obvs that last one only really works when as-yet-unreleased is in fact released
well I'm not going to release this immediately so I guess this pull request can sit here for a bit and I will see whether I still buy that reasoning later...