Add wake_up parameter to rigidbody methods #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebcrozet
requested changes
Oct 12, 2020
There was a problem hiding this comment.
Thank you for this PR!
- All the
self.wake_up(false)should beself.wake_up(true). This will perform a "strong" wake-up, casing the rigid-body to stay awake for a couple of frames. - All the
if wake_up { ... }should happen only ifself.body_status == BodyStatus::Dynamic. - The
apply_*_at_point()should just forward thewake_upparameter to the methods it calls. This will make maintainance simpler.
sebcrozet
added
breaking change
sebcrozet
approved these changes
Nov 19, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add boolean parameter to rigid body methods as discussed in #5
Closes #5