Skip to content
This repository has been archived by the owner on Apr 22, 2022. It is now read-only.

Add a production ready Dockerfile #45

Closed
dimiro1 opened this issue Nov 26, 2018 · 3 comments
Closed

Add a production ready Dockerfile #45

dimiro1 opened this issue Nov 26, 2018 · 3 comments

Comments

@dimiro1
Copy link
Owner

dimiro1 commented Nov 26, 2018

Should we load the config with only one app and load the secrets with env vars?

@bmartel
Copy link

bmartel commented Dec 5, 2018

You may want to look at possibly abstracting both and handling them with https://github.com/spf13/viper. This would keep both secret env vars and any configuration files you need to depend on available through a unified api within the code (consumes many forms of environment/config data). This would open up many more possibilities with how the application itself can be deployed or managed within a container, or in any scenario really.

@dimiro1
Copy link
Owner Author

dimiro1 commented Dec 6, 2018

Hey, @bmartel thanks for your comment. How to handle multiple applications using only env vars?

@dimiro1
Copy link
Owner Author

dimiro1 commented Dec 8, 2018

Hey, @bmartel I just merged #46 which adds a Dockerfile to the project, however, I still like your suggestion to use Viper to configure the application. Feel free to open a PR with the Viper implementation, I will be more than happy to accept it.

@dimiro1 dimiro1 closed this as completed Dec 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants